xfs
[Top] [All Lists]

Re: [PATCH 12/12] xfs: remove duplication in transaction buffer operatio

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/12] xfs: remove duplication in transaction buffer operations
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 17 Dec 2011 18:32:38 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1323238703-13198-13-git-send-email-david@xxxxxxxxxxxxx>
References: <1323238703-13198-1-git-send-email-david@xxxxxxxxxxxxx> <1323238703-13198-13-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> @@ -213,8 +147,6 @@ xfs_trans_get_buf_irec(
>       struct xfs_buf          *bp;
>       struct xfs_buf_log_item *bip;
>  
> -     ASSERT_ALWAYS(nmaps == 1);
> -

Shouldn't this have been removed as soon as actual multiple buffer
support was introduced?

> @@ -528,8 +303,6 @@ xfs_trans_read_buf_irec(
>       xfs_buf_log_item_t      *bip;
>       int                     error;
>  
> -     ASSERT_ALWAYS(nmaps == 1);
> -

Same here.

<Prev in Thread] Current Thread [Next in Thread>