xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix acl count validation in xfs_acl_from_disk()

To: Xi Wang <xi.wang@xxxxxxxxx>
Subject: Re: [PATCH] xfs: fix acl count validation in xfs_acl_from_disk()
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 16 Dec 2011 15:19:16 -0600
Cc: Christoph Hellwig <hch@xxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <1323726952-22963-1-git-send-email-xi.wang@xxxxxxxxx>
References: <1323726952-22963-1-git-send-email-xi.wang@xxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Dec 12, 2011 at 04:55:52PM -0500, Xi Wang wrote:
> Commit fa8b18ed didn't prevent the integer overflow and possible
> memory corruption.  "count" can go negative and bypass the check.
> 
> Signed-off-by: Xi Wang <xi.wang@xxxxxxxxx>

Looks good.  Nice catch!
Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>