xfs
[Top] [All Lists]

Re: [patch 16/19] xfs: add a xfs_dqhold helper

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 16/19] xfs: add a xfs_dqhold helper
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 15 Dec 2011 10:56:53 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111206215855.483263030@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215855.483263030@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 06, 2011 at 04:58:22PM -0500, Christoph Hellwig wrote:
> Factor the common pattern of:
> 
>       xfs_dqlock(dqp);
>       XFS_DQHOLD(dqp);
>       xfs_dqunlock(dqp);
> 
> into a new helper, and remove XFS_DQHOLD now that only one other caller
> is left.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.
Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>