Re: [patch 16/19] xfs: add a xfs

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [patch 16/19] xfs: add a xfs_dqhold helper
From:	Ben Myers <bpm@xxxxxxx>
Date:	Thu, 15 Dec 2011 10:56:53 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20111206215855.483263030@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215855.483263030@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Dec 06, 2011 at 04:58:22PM -0500, Christoph Hellwig wrote:
> Factor the common pattern of:
> 
>       xfs_dqlock(dqp);
>       XFS_DQHOLD(dqp);
>       xfs_dqunlock(dqp);
> 
> into a new helper, and remove XFS_DQHOLD now that only one other caller
> is left.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.
Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [patch 14/19] xfs: simplify xfs_qm_dqattach_grouphint, (continued) Re: [patch 14/19] xfs: simplify xfs_qm_dqattach_grouphint, Ben Myers [patch 02/19] xfs: cleanup the transaction commit path a bit, Christoph Hellwig Re: [patch 02/19] xfs: cleanup the transaction commit path a bit, Ben Myers [patch 08/19] xfs: cleanup dquot locking helpers, Christoph Hellwig Re: [patch 08/19] xfs: cleanup dquot locking helpers, Ben Myers [patch 17/19] xfs: merge xfs_qm_dqinit_core into the only caller, Christoph Hellwig Re: [patch 17/19] xfs: merge xfs_qm_dqinit_core into the only caller, Ben Myers [patch 13/19] xfs: nest qm_dqfrlist_lock inside the dquot qlock, Christoph Hellwig Re: [patch 13/19] xfs: nest qm_dqfrlist_lock inside the dquot qlock, Ben Myers [patch 16/19] xfs: add a xfs_dqhold helper, Christoph Hellwig Re: [patch 16/19] xfs: add a xfs_dqhold helper, Ben Myers <= [patch 19/19] xfs: remove XFS_QMOPT_DQSUSER, Christoph Hellwig Re: [patch 19/19] xfs: remove XFS_QMOPT_DQSUSER, Ben Myers [patch 12/19] xfs: flatten the dquot lock ordering, Christoph Hellwig Re: [patch 12/19] xfs: flatten the dquot lock ordering, Dave Chinner Re: [patch 12/19] xfs: flatten the dquot lock ordering, Ben Myers Re: [patch 12/19] xfs: flatten the dquot lock ordering, Ben Myers [patch 18/19] xfs: kill xfs_qm_idtodq, Christoph Hellwig Re: [patch 18/19] xfs: kill xfs_qm_idtodq, Ben Myers

Previous by Date:	Re: [patch 15/19] xfs: simplify xfs_qm_detach_gdquots, Ben Myers
Next by Date:	Re: [patch 17/19] xfs: merge xfs_qm_dqinit_core into the only caller, Ben Myers
Previous by Thread:	[patch 16/19] xfs: add a xfs_dqhold helper, Christoph Hellwig
Next by Thread:	[patch 19/19] xfs: remove XFS_QMOPT_DQSUSER, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [patch 16/19] xfs: add a xfs_dqhold helper