xfs
[Top] [All Lists]

Re: [patch 12/19] xfs: flatten the dquot lock ordering

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 12/19] xfs: flatten the dquot lock ordering
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 14 Dec 2011 21:13:33 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111206215854.769664827@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215854.769664827@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 06, 2011 at 04:58:18PM -0500, Christoph Hellwig wrote:
> Index: xfs/fs/xfs/xfs_dquot.c
> ===================================================================
> @@ -781,11 +787,7 @@ xfs_qm_dqget(
>                       return (EIO);
>               }
>       }
> -#endif
>  
> - again:
> -
> -#ifdef DEBUG

Meant to say... moving the goto tag below doesn't look like it was
strictly necessary, but it didn't look like it was possible to get here
without the ilock held anyway.

<Prev in Thread] Current Thread [Next in Thread>