xfs
[Top] [All Lists]

Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 14 Dec 2011 08:27:10 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111213232017.GH3179@dastard>
References: <20111208155755.323930705@xxxxxxxxxxxxxxxxxxxxxx> <20111208155919.215723395@xxxxxxxxxxxxxxxxxxxxxx> <20111213232017.GH3179@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 14, 2011 at 10:20:17AM +1100, Dave Chinner wrote:
> On Thu, Dec 08, 2011 at 10:58:05AM -0500, Christoph Hellwig wrote:
> > While xfs_iunlock is fine with 0 lockflags the calling conventions are much
> > cleaner if xfs_file_aio_write_checks never returns without the iolock held.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> I'm not sure this makes sense by itself. maybe combine it with the
> next patch? Regardless:

I actually had it that way initially but split the patches because the
changes aren't directly related.

<Prev in Thread] Current Thread [Next in Thread>