| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 11/11] xfs: cleanup xfs_file_aio_write |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 14 Dec 2011 10:28:17 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20111208155919.391725161@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20111208155755.323930705@xxxxxxxxxxxxxxxxxxxxxx> <20111208155919.391725161@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 08, 2011 at 10:58:06AM -0500, Christoph Hellwig wrote: > With all the size field updates out of the way xfs_file_aio_write can > be further simplified by pushing all iolock handling into > xfs_file_dio_aio_write and xfs_file_buffered_aio_write and using > the generic generic_write_sync helper for synchronous writes. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks ok to me. The whole series cleans up the IO path nicely. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | xfs-trace-ilock-more, Christoph Hellwig |
|---|---|
| Next by Date: | [PATCH] xfstests: open btrfsck to check the btrfs filesystem, Miao Xie |
| Previous by Thread: | [PATCH 11/11] xfs: cleanup xfs_file_aio_write, Christoph Hellwig |
| Next by Thread: | [PATCH 06/11] xfs: replace i_flock with a sleeping bitlock, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |