Re: [PATCH 07/11] xfs: replace i_pin_wait with a bit waitqueue

xfs

Re: [PATCH 07/11] xfs: replace i_pin_wait with a bit waitqueue

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 07/11] xfs: replace i_pin_wait with a bit waitqueue
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 14 Dec 2011 09:21:58 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20111208155918.662107724@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20111208155755.323930705@xxxxxxxxxxxxxxxxxxxxxx> <20111208155918.662107724@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Dec 08, 2011 at 10:58:02AM -0500, Christoph Hellwig wrote:
> Replace i_pin_wait, which is only used during synchronous inode flushing
> with a bit waitqueue.  This trades off a much smaller inode against
> slightly slower wakeup performance, and saves 12 (32-bit) or 20 (64-bit)
> bytes in the XFS inode.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Alex Elder <aelder@xxxxxxx>

Looks fine - the pinning code never modifies the i_flags field, so
doesn't require the i_flags_lock anywhere so the concerns i had
about the previous patch are not relevant here...

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/11] inode shrink and misc updates, Christoph Hellwig [PATCH 03/11] xfs: remove the unused dm_attrs structure, Christoph Hellwig [PATCH 02/11] xfs: cleanup xfs_iomap_eof_align_last_fsb, Christoph Hellwig Re: [PATCH 02/11] xfs: cleanup xfs_iomap_eof_align_last_fsb, Dave Chinner [PATCH 07/11] xfs: replace i_pin_wait with a bit waitqueue, Christoph Hellwig Re: [PATCH 07/11] xfs: replace i_pin_wait with a bit waitqueue, Dave Chinner <= [PATCH 05/11] xfs: make i_flags an unsigned long, Christoph Hellwig [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks, Christoph Hellwig Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks, Dave Chinner Re: [PATCH 10/11] xfs: always return with the iolock held from xfs_file_aio_write_checks, Christoph Hellwig [PATCH 01/11] xfs: remove xfs_itruncate_data, Christoph Hellwig Re: [PATCH 01/11] xfs: remove xfs_itruncate_data, Dave Chinner [PATCH 09/11] xfs: remove the i_new_size field in struct xfs_inode, Christoph Hellwig Re: [PATCH 09/11] xfs: remove the i_new_size field in struct xfs_inode, Dave Chinner Re: [PATCH 09/11] xfs: remove the i_new_size field in struct xfs_inode, Christoph Hellwig [PATCH 04/11] xfs: remove the if_ext_max field in struct xfs_ifork, Christoph Hellwig

Previous by Date:	Re: [PATCH 06/11] xfs: replace i_flock with a sleeping bitlock, Dave Chinner
Next by Date:	Re: XFS updates for 3.0-stable, Greg KH
Previous by Thread:	[PATCH 07/11] xfs: replace i_pin_wait with a bit waitqueue, Christoph Hellwig
Next by Thread:	[PATCH 05/11] xfs: make i_flags an unsigned long, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]