[Top] [All Lists]

Re: [patch 12/19] xfs: flatten the dquot lock ordering

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 12/19] xfs: flatten the dquot lock ordering
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 14 Dec 2011 06:44:57 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111206215854.769664827@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215854.769664827@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 06, 2011 at 04:58:18PM -0500, Christoph Hellwig wrote:
> Introduce a new XFS_DQ_FREEING flag that tells lookup and mplist walks
> to skip a dquot that is beeing freed, and use this avoid the trylock
> on the hash and mplist locks in xfs_qm_dqreclaim_one.  Also simplify
> xfs_dqpurge by moving the inodes to a dispose list after marking them
> XFS_DQ_FREEING and avoid the locker ordering constraints.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good to me withthe coment updates.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>