Re: [PATCH 08/12] repair: handle filesystems with the log in allocation

xfs

Re: [PATCH 08/12] repair: handle filesystems with the log in allocation

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 08/12] repair: handle filesystems with the log in allocation group 0
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Tue, 13 Dec 2011 13:36:48 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20111202174742.515301323@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20111202174619.179530033@xxxxxxxxxxxxxxxxxxxxxx> <20111202174742.515301323@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Dec 02, 2011 at 12:46:27PM -0500, Christoph Hellwig wrote:
> Sindre Skogen reported that repair chokes on a very small filesystem created
> by mkfs.xfs from xfsprogs 2.9.4.  It turned out that for some reason this
> filesystem had the log in allocation group 0 and thus repairs validation
> of the root inode number was off.  Fix this by adding the log blocks if
> the log is allocated in allocation group 0.
> 
> Reported-by: Sindre Skogen <sindre@xxxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good - handling all occurrences of the log in AG 0 is much
nicer.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 05/12] repair: update extent count after zapping duplicate blocks, (continued) Re: [PATCH 05/12] repair: update extent count after zapping duplicate blocks, Dave Chinner [PATCH 03/12] repair: allocate and free extent records individually, Christoph Hellwig Re: [PATCH 03/12] repair: allocate and free extent records individually, Dave Chinner [PATCH 09/12] repair: kill check_inode_block, Christoph Hellwig [PATCH 02/12] repair: allocate and free inode records individually, Christoph Hellwig Re: [PATCH 02/12] repair: allocate and free inode records individually, Dave Chinner [PATCH 12/12] repair: cleanup inode record macros, Christoph Hellwig [PATCH 10/12] repair: mark local functions static, Christoph Hellwig [PATCH 11/12] repair: move extern declarations to headers, Christoph Hellwig [PATCH 08/12] repair: handle filesystems with the log in allocation group 0, Christoph Hellwig Re: [PATCH 08/12] repair: handle filesystems with the log in allocation group 0, Dave Chinner <= [PATCH 01/12] repair: do not walk the unlinked inode list, Christoph Hellwig Re: [PATCH 01/12] repair: do not walk the unlinked inode list, Dave Chinner [PATCH 06/12] repair: use recursive buffer locking, Christoph Hellwig Re: [PATCH 06/12] repair: use recursive buffer locking, Dave Chinner Re: [PATCH 06/12] repair: use recursive buffer locking, Christoph Hellwig

Previous by Date:	Re: [PATCH 07/12] repair: fix another ABBA deadlock in inode prefetching, Dave Chinner
Next by Date:	Re: [PATCH] mkfs: Refuse to initialize a misaligned device if not forced using libblkid, Eric Sandeen
Previous by Thread:	[PATCH 08/12] repair: handle filesystems with the log in allocation group 0, Christoph Hellwig
Next by Thread:	[PATCH 01/12] repair: do not walk the unlinked inode list, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]