Re: [PATCH 03/12] repair: allocate and free extent records individually

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 03/12] repair: allocate and free extent records individually
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Tue, 13 Dec 2011 10:21:40 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20111202174741.504430987@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20111202174619.179530033@xxxxxxxxxxxxxxxxxxxxxx> <20111202174741.504430987@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Dec 02, 2011 at 12:46:22PM -0500, Christoph Hellwig wrote:
> Instead of allocating inode records in chunks and keeping a freelist of them
> which gets released to the system memory allocator in one go use plain malloc
> and free for them.  The freelist just means adding a global lock instead
> of relying on malloc and free which could be implemented lockless.  In
> addition smart allocators like tcmalloc have far less overhead than our
> chunk and linked list.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Same context as the last patch - seems much better to rely on malloc
to get this right.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/12] xfs_repair queue, Christoph Hellwig [PATCH 04/12] xfsprogs: allow linking against libtcmalloc, Christoph Hellwig Re: [PATCH 04/12] xfsprogs: allow linking against libtcmalloc, Dave Chinner Re: [PATCH 04/12] xfsprogs: allow linking against libtcmalloc, Christoph Hellwig [PATCH 07/12] repair: fix another ABBA deadlock in inode prefetching, Christoph Hellwig Re: [PATCH 07/12] repair: fix another ABBA deadlock in inode prefetching, Dave Chinner [PATCH 05/12] repair: update extent count after zapping duplicate blocks, Christoph Hellwig Re: [PATCH 05/12] repair: update extent count after zapping duplicate blocks, Dave Chinner [PATCH 03/12] repair: allocate and free extent records individually, Christoph Hellwig Re: [PATCH 03/12] repair: allocate and free extent records individually, Dave Chinner <= [PATCH 09/12] repair: kill check_inode_block, Christoph Hellwig [PATCH 02/12] repair: allocate and free inode records individually, Christoph Hellwig Re: [PATCH 02/12] repair: allocate and free inode records individually, Dave Chinner [PATCH 12/12] repair: cleanup inode record macros, Christoph Hellwig [PATCH 10/12] repair: mark local functions static, Christoph Hellwig [PATCH 11/12] repair: move extern declarations to headers, Christoph Hellwig [PATCH 08/12] repair: handle filesystems with the log in allocation group 0, Christoph Hellwig Re: [PATCH 08/12] repair: handle filesystems with the log in allocation group 0, Dave Chinner [PATCH 01/12] repair: do not walk the unlinked inode list, Christoph Hellwig Re: [PATCH 01/12] repair: do not walk the unlinked inode list, Dave Chinner

Previous by Date:	Re: [PATCH 02/12] repair: allocate and free inode records individually, Dave Chinner
Next by Date:	Re: [PATCH 04/12] xfsprogs: allow linking against libtcmalloc, Dave Chinner
Previous by Thread:	[PATCH 03/12] repair: allocate and free extent records individually, Christoph Hellwig
Next by Thread:	[PATCH 09/12] repair: kill check_inode_block, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]