xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix acl count validation in xfs_acl_from_disk()

To: Xi Wang <xi.wang@xxxxxxxxx>
Subject: Re: [PATCH] xfs: fix acl count validation in xfs_acl_from_disk()
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 12 Dec 2011 23:42:27 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Ben Myers <bpm@xxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1323726952-22963-1-git-send-email-xi.wang@xxxxxxxxx>
References: <1323726952-22963-1-git-send-email-xi.wang@xxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Mon, Dec 12, 2011 at 04:55:52PM -0500, Xi Wang wrote:
> Commit fa8b18ed didn't prevent the integer overflow and possible
> memory corruption.  "count" can go negative and bypass the check.

Thanks, this looks good to me.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>