xfs
[Top] [All Lists]

[patch 08/12] xfs: add xlog_grant_head_wake_all

To: xfs@xxxxxxxxxxx
Subject: [patch 08/12] xfs: add xlog_grant_head_wake_all
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 12 Dec 2011 09:13:55 -0500
References: <20111212141346.986825692@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.48-1
Signed-off-by: Christoph Hellwig <hch@xxxxxx>

---
 fs/xfs/xfs_log.c |   24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

Index: xfs/fs/xfs/xfs_log.c
===================================================================
--- xfs.orig/fs/xfs/xfs_log.c   2011-12-11 21:28:56.364682358 +0100
+++ xfs/fs/xfs/xfs_log.c        2011-12-11 21:28:57.128011556 +0100
@@ -159,6 +159,18 @@ xlog_grant_head_init(
        spin_lock_init(&head->lock);
 }
 
+STATIC void
+xlog_grant_head_wake_all(
+       struct xlog_grant_head  *head)
+{
+       struct xlog_ticket      *tic;
+
+       spin_lock(&head->lock);
+       list_for_each_entry(tic, &head->waiters, t_queue)
+               wake_up_process(tic->t_task);
+       spin_unlock(&head->lock);
+}
+
 STATIC bool
 xlog_reserveq_wake(
        struct log              *log,
@@ -3557,7 +3569,6 @@ xfs_log_force_umount(
        struct xfs_mount        *mp,
        int                     logerror)
 {
-       xlog_ticket_t   *tic;
        xlog_t          *log;
        int             retval;
 
@@ -3625,15 +3636,8 @@ xfs_log_force_umount(
         * we don't enqueue anything once the SHUTDOWN flag is set, and this
         * action is protected by the grant locks.
         */
-       spin_lock(&log->l_reserve_head.lock);
-       list_for_each_entry(tic, &log->l_reserve_head.waiters, t_queue)
-               wake_up_process(tic->t_task);
-       spin_unlock(&log->l_reserve_head.lock);
-
-       spin_lock(&log->l_write_head.lock);
-       list_for_each_entry(tic, &log->l_write_head.waiters, t_queue)
-               wake_up_process(tic->t_task);
-       spin_unlock(&log->l_write_head.lock);
+       xlog_grant_head_wake_all(&log->l_reserve_head);
+       xlog_grant_head_wake_all(&log->l_write_head);
 
        if (!(log->l_iclog->ic_state & XLOG_STATE_IOERROR)) {
                ASSERT(!logerror);

<Prev in Thread] Current Thread [Next in Thread>