xfs
[Top] [All Lists]

Re: [patch 03/19] xfs: remove the lid_size field in struct log_item_desc

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 03/19] xfs: remove the lid_size field in struct log_item_desc
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 8 Dec 2011 12:35:47 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111206215853.103470363@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215853.103470363@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 06, 2011 at 04:58:09PM -0500, Christoph Hellwig wrote:
> Outside the now removed nodelaylog code this field is only used for
> asserts and can be safely removed now.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.
Reviewed-by: Ben Myers <bpm@xxxxxxx>

> Index: xfs/fs/xfs/xfs_inode_item.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_inode_item.c  2011-12-06 15:26:35.150334172 +0100
> +++ xfs/fs/xfs/xfs_inode_item.c       2011-12-06 15:36:07.963678127 +0100
> @@ -437,7 +437,6 @@ xfs_inode_item_format(
>        * Assert that no attribute-related log flags are set.
>        */
>       if (!XFS_IFORK_Q(ip)) {
> -             ASSERT(nvecs == lip->li_desc->lid_size);
>               iip->ili_format.ilf_size = nvecs;
>               ASSERT(!(iip->ili_format.ilf_fields &
>                        (XFS_ILOG_ADATA | XFS_ILOG_ABROOT | XFS_ILOG_AEXT)));
> @@ -521,7 +520,6 @@ xfs_inode_item_format(
>               break;
>       }
>  
> -     ASSERT(nvecs == lip->li_desc->lid_size);

These two look like they might have been useful.

<Prev in Thread] Current Thread [Next in Thread>