xfs
[Top] [All Lists]

Re: [patch 02/19] xfs: cleanup the transaction commit path a bit

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 02/19] xfs: cleanup the transaction commit path a bit
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 8 Dec 2011 11:44:38 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111206215852.919749164@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215852.919749164@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 06, 2011 at 04:58:08PM -0500, Christoph Hellwig wrote:
> Now that the nodelaylog mode is gone we can simplify the transaction commit
> path a bit by removing the xfs_trans_commit_cil routine.  Restoring the
> process flags is merged into xfs_trans_commit which already does it for
> the error path, and allocating the log vectors is merged into
> xlog_cil_format_items, which already fills them with data, thus avoiding
> one loop over all log items.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.
Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>