xfs
[Top] [All Lists]

Re: [patch 01/19] xfs: remove the deprecated nodelaylog option

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 01/19] xfs: remove the deprecated nodelaylog option
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 8 Dec 2011 10:14:57 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111208161210.GA6326@xxxxxxxxxxxxx>
References: <20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215852.699758135@xxxxxxxxxxxxxxxxxxxxxx> <20111207214453.GR29840@xxxxxxx> <20111208161210.GA6326@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Dec 08, 2011 at 11:12:10AM -0500, Christoph Hellwig wrote:
> On Wed, Dec 07, 2011 at 03:44:53PM -0600, Ben Myers wrote:
> > > - log->l_cilp = NULL;
> > > - if (!(log->l_mp->m_flags & XFS_MOUNT_DELAYLOG))
> > > -         return 0;
> > > -
> > 
> > There is a section of comment above xlog_cil_init that only applies if
> > we could still switch the CIL off.  It should be removed with this
> > patch.
> 
> Indeed.  If there's enough comments that I need to respin the series
> I'll remove it.  If not please just remove it for while commiting the
> patch.

Good.  I'll remove the comment. 

-Ben

<Prev in Thread] Current Thread [Next in Thread>