xfs
[Top] [All Lists]

Re: [patch 01/19] xfs: remove the deprecated nodelaylog option

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [patch 01/19] xfs: remove the deprecated nodelaylog option
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 8 Dec 2011 11:12:10 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111207214453.GR29840@xxxxxxx>
References: <20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215852.699758135@xxxxxxxxxxxxxxxxxxxxxx> <20111207214453.GR29840@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 07, 2011 at 03:44:53PM -0600, Ben Myers wrote:
> > -   log->l_cilp = NULL;
> > -   if (!(log->l_mp->m_flags & XFS_MOUNT_DELAYLOG))
> > -           return 0;
> > -
> 
> There is a section of comment above xlog_cil_init that only applies if
> we could still switch the CIL off.  It should be removed with this
> patch.

Indeed.  If there's enough comments that I need to respin the series
I'll remove it.  If not please just remove it for while commiting the
patch.

<Prev in Thread] Current Thread [Next in Thread>