xfs
[Top] [All Lists]

Re: [patch 01/19] xfs: remove the deprecated nodelaylog option

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 01/19] xfs: remove the deprecated nodelaylog option
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 7 Dec 2011 15:44:53 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111206215852.699758135@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111206215806.844405397@xxxxxxxxxxxxxxxxxxxxxx> <20111206215852.699758135@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 06, 2011 at 04:58:07PM -0500, Christoph Hellwig wrote:
> The delaylog mode has been the default for a long time, and the nodelaylog
> option has been scheduled for removal in Linux 3.3.  Remove it and code
> only used by it now that we have opened the 3.3 window.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good, one comment below.
Reviewed-by: Ben Myers <bpm@xxxxxxx>

> Index: xfs/fs/xfs/xfs_log_cil.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_log_cil.c     2011-11-28 09:13:10.684813018 +0100
> +++ xfs/fs/xfs/xfs_log_cil.c  2011-11-28 09:17:38.320029780 +0100
> @@ -44,10 +44,6 @@ xlog_cil_init(

>       struct xfs_cil  *cil;
>       struct xfs_cil_ctx *ctx;
>  
> -     log->l_cilp = NULL;
> -     if (!(log->l_mp->m_flags & XFS_MOUNT_DELAYLOG))
> -             return 0;
> -

There is a section of comment above xlog_cil_init that only applies if
we could still switch the CIL off.  It should be removed with this
patch.

<Prev in Thread] Current Thread [Next in Thread>