xfs
[Top] [All Lists]

Re: [PATCH] xfstests/071 FAIL with pwrite64: Invalid argument

To: david@xxxxxxxxxxxxx
Subject: Re: [PATCH] xfstests/071 FAIL with pwrite64: Invalid argument
From: Peng Haitao <penght@xxxxxxxxxxxxxx>
Date: Wed, 07 Dec 2011 16:17:55 +0800
Cc: hch@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20111206110533.GD28326@dastard>
References: <4EDD8F16.4050402@xxxxxxxxxxxxxx> <20111206110533.GD28326@dastard>
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111105 Thunderbird/8.0
Hi, 

Dave Chinner said the following on 2011-12-6 19:05:
>> When offset + length is overflow of xfs_io builtin pread and pwrite in linux,
>> the error message should be "Invalid argument".
> 
> Fixing this just requires an additional filter. The write outpu is
> already passed through 2 filters to remove ariable numbers from the
> output, so one more to standardise the error isn't a problem.
> 
> Further, filtering of the error stream on the reads to only appear
> in $seq.full solves the extra error output on reads as well.
> 

Thanks for your comments.

When offset + length is overflow, the case expect:
  - pwrite output error messages: pwrite64: File too large
  - pread output right message:   read 0/512 bytes at offset <OFFSET>

but in linux, the actual results:
  - pwrite output error messages: pwrite64: Invalid argument
  - pread output right message:   pread64: Invalid argument

I can add an additional filter to remove variable messages, 
but if I remove variable messages, the 071.out will remain echo content:
Writing 512 bytes, offset is +0 (direct=false)
Reading 512 bytes (direct=false)
...

This will make the case meaningless.

-- 
Best Regards,
Peng Haitao

<Prev in Thread] Current Thread [Next in Thread>