xfs
[Top] [All Lists]

Re: [PATCH] xfstests/071 FAIL with pwrite64: Invalid argument

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests/071 FAIL with pwrite64: Invalid argument
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 6 Dec 2011 06:23:50 -0500
Cc: Peng Haitao <penght@xxxxxxxxxxxxxx>, hch@xxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: <20111206110533.GD28326@dastard>
References: <4EDD8F16.4050402@xxxxxxxxxxxxxx> <20111206110533.GD28326@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 06, 2011 at 10:05:33PM +1100, Dave Chinner wrote:
> On Tue, Dec 06, 2011 at 11:42:14AM +0800, Peng Haitao wrote:
> > 
> > When offset + length is overflow of xfs_io builtin pread and pwrite in 
> > linux,
> > the error message should be "Invalid argument".
> 
> Fixing this just requires an additional filter. The write outpu is
> already passed through 2 filters to remove ariable numbers from the
> output, so one more to standardise the error isn't a problem.
> 
> Further, filtering of the error stream on the reads to only appear
> in $seq.full solves the extra error output on reads as well.

Yes, I was about to say the same.  Also now that it passes please add
the test to the "auto" group.

<Prev in Thread] Current Thread [Next in Thread>