xfs
[Top] [All Lists]

Re: [PATCH 09/16] xfs: flatten the dquot lock ordering

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/16] xfs: flatten the dquot lock ordering
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2011 06:50:21 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111205093437.GA28326@dastard>
References: <20111128082722.604873274@xxxxxxxxxxxxxxxxxxxxxx> <20111128082837.808570926@xxxxxxxxxxxxxxxxxxxxxx> <20111205050428.GP7046@dastard> <20111205091121.GA22018@xxxxxxxxxxxxx> <20111205093437.GA28326@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 05, 2011 at 08:34:37PM +1100, Dave Chinner wrote:
> Hmmmm. My unmodified tree just has the declaration without
> initialisation, and I didn't find any place where the initialisation
> was added in the preceding patches. I'll go back and have another
> look.

It's actually in this patch:

@@ -489,8 +498,8 @@ xfs_qm_dqpurge_int(
        struct xfs_quotainfo    *q = mp->m_quotainfo;
        struct xfs_dquot        *dqp, *n;
        uint                    dqtype;
-       int                     nrecl;
-       int                     nmisses;
+       int                     nmisses = 0;
+       LIST_HEAD               (dispose_list);

<Prev in Thread] Current Thread [Next in Thread>