xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfs: cleanup the transaction commit path a bit

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] xfs: cleanup the transaction commit path a bit
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2011 03:35:34 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111205035516.GF7046@dastard>
References: <20111128082522.224645690@xxxxxxxxxxxxxxxxxxxxxx> <20111128082557.082085349@xxxxxxxxxxxxxxxxxxxxxx> <20111205035516.GF7046@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 05, 2011 at 02:55:16PM +1100, Dave Chinner wrote:
> > + *
> > + * Note that this format differs from the old log vector format in that 
> > there
> > + * is no transaction header in these log vectors.
> 
> Do we even need this comment given the old itransaction commit code
> that did this is now gone?

We could probably drop this, yes.

> Would it make sense to have IOP_FORMAT return the length of the
> vectors (calculated as itis built) rather than having to add them up
> after the fact? That would avoid an extra pass across the vector
> array. Regardless, it can be done as a future patch...

I have a WIP patch for that, but it's not quite ready yet.

<Prev in Thread] Current Thread [Next in Thread>