[Top] [All Lists]

Re: [PATCH 12/16] xfs: simplify xfs_qm_detach_gdquots

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/16] xfs: simplify xfs_qm_detach_gdquots
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2011 16:18:43 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111128082838.328519173@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111128082722.604873274@xxxxxxxxxxxxxxxxxxxxxx> <20111128082838.328519173@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 28, 2011 at 03:27:34AM -0500, Christoph Hellwig wrote:
> With the new lock order there is no reason to drop qi_dqlist_lock around
> calls to xfs_qm_dqrele.

.... because the free list lock now nests inside the qi_dqlist_lock and
the dquot lock.

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 12/16] xfs: simplify xfs_qm_detach_gdquots, Dave Chinner <=