Re: [PATCH 06/16] xfs: cleanup xfs_qm_dqlookup

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Mon, Nov 28, 2011 at 03:27:28AM -0500, Christoph Hellwig wrote:
> Rearrange the code to avoid the conditional locking around the flist_locked
> variable.  This means we lose a (rather pointless) assert, and hold the
> freelist lock a bit longer for one corner case.

Hardly worth mentioning that corner case - all we do is hold the
mutex while doing a XFS_DQHOLD() instead of dropping it first, which
we do for the other case, anyway.

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Otherwise,

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>


-- 
Dave Chinner
david@xxxxxxxxxxxxx