[Top] [All Lists]

Re: [PATCH 06/16] xfs: cleanup xfs_qm_dqlookup

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/16] xfs: cleanup xfs_qm_dqlookup
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2011 15:17:32 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111128082837.263453373@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111128082722.604873274@xxxxxxxxxxxxxxxxxxxxxx> <20111128082837.263453373@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 28, 2011 at 03:27:28AM -0500, Christoph Hellwig wrote:
> Rearrange the code to avoid the conditional locking around the flist_locked
> variable.  This means we lose a (rather pointless) assert, and hold the
> freelist lock a bit longer for one corner case.

Hardly worth mentioning that corner case - all we do is hold the
mutex while doing a XFS_DQHOLD() instead of dropping it first, which
we do for the other case, anyway.

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>


Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 06/16] xfs: cleanup xfs_qm_dqlookup, Dave Chinner <=