xfs
[Top] [All Lists]

Re: [PATCH 03/16] xfs: remove xfs_qm_sync

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 03/16] xfs: remove xfs_qm_sync
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2011 15:09:17 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111128082836.676707771@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111128082722.604873274@xxxxxxxxxxxxxxxxxxxxxx> <20111128082836.676707771@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 28, 2011 at 03:27:25AM -0500, Christoph Hellwig wrote:
> Now that we can't have any dirty dquots around that aren't in the AIL we
> can get rid of the explicit dquot syncing from xfssyncd and xfs_fs_sync_fs.

Makes sense - but it does mean that we now completely rely on log
recovery to be correct when someone issues a sync from userspace to
ensure quotas are consistent after a crash. maybe that is worth
mentioning in the commit message....

Otherwise,

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 03/16] xfs: remove xfs_qm_sync, Dave Chinner <=