xfs
[Top] [All Lists]

[XFS updates] XFS development tree branch, master, updated. v3.2-rc1-9-g

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, master, updated. v3.2-rc1-9-ga99ebf4
From: xfs@xxxxxxxxxxx
Date: Fri, 2 Dec 2011 16:12:36 -0600
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, master has been updated
  a99ebf4 xfs: fix allocation length overflow in xfs_bmapi_write()
      from  4c393a6059f8442a70512a48ce4639b882b6f6ad (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a99ebf43f49f4499ab0e2a8a9132ad6ed6ba2409
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Thu Dec 1 11:24:20 2011 +0000

    xfs: fix allocation length overflow in xfs_bmapi_write()
    
    When testing the new xfstests --large-fs option that does very large
    file preallocations, this assert was tripped deep in
    xfs_alloc_vextent():
    
    XFS: Assertion failed: args->minlen <= args->maxlen, file: 
fs/xfs/xfs_alloc.c, line: 2239
    
    The allocation was trying to allocate a zero length extent because
    the lower 32 bits of the allocation length was zero. The remaining
    length of the allocation to be done was an exact multiple of 2^32 -
    the first case I saw was at 496TB remaining to be allocated.
    
    This turns out to be an overflow when converting the allocation
    length (a 64 bit quantity) into the extent length to allocate (a 32
    bit quantity), and it requires the length to be allocated an exact
    multiple of 2^32 blocks to trip the assert.
    
    Fix it by limiting the extent lenth to allocate to MAXEXTLEN.
    
    Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Signed-off-by: Ben Myers <bpm@xxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/xfs_bmap.c |   20 +++++++++++++++++++-
 1 files changed, 19 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, master, updated. v3.2-rc1-9-ga99ebf4, xfs <=