xfs
[Top] [All Lists]

Re: [PATCH 5/4] xfs: fix nfs export of 64-bit inodes numbers on 32-bit k

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/4] xfs: fix nfs export of 64-bit inodes numbers on 32-bit kernels
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 2 Dec 2011 10:07:12 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111130085817.GA22471@xxxxxxxxxxxxx>
References: <20111128081732.350228200@xxxxxxxxxxxxxxxxxxxxxx> <20111130085817.GA22471@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
Hey Christoph,

On Wed, Nov 30, 2011 at 03:58:18AM -0500, Christoph Hellwig wrote:
> The i_ino field in the VFS inode is of type unsigned long and thus can't
> hold the full 64-bit inode number on 32-bit kernels.  We have the full
> inode number in the XFS inode, so use that one for nfs exports.  Note
> that I've also switched the 32-bit file handles types to it, just to make
> the code more consistent and copy & paste errors less likely to happen.
> 
> Reported-by: Guoquan Yang <ygq51@xxxxxxxxxxx>
> Reported-by: Hank Peng <pengxihan@xxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

To what extent did you test this one?  Anything in particular I should
look for when I test it?

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>