xfs
[Top] [All Lists]

[PATCH] mkfs: Refuse to initialize a misaligned device if not forced usi

To: xfs@xxxxxxxxxxx
Subject: [PATCH] mkfs: Refuse to initialize a misaligned device if not forced using libblkid
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Thu, 1 Dec 2011 10:44:25 -0200
Cc: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
This is the first patch proposal to fix the problem about the usage of
4k sector devices when the device is not properly aligned

The patch make mkfs to refuse to initialize a xfs filesystem if the -f
option is not passed at the command line, and forces a 512b sector size
if the user opt to force the device initialization

Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
---
 mkfs/xfs_mkfs.c |   24 ++++++++++++++++++------
 1 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index f527f3d..495c70d 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -369,8 +369,14 @@ out:
        return ret;
 }
 
-static void blkid_get_topology(const char *device, int *sunit, int *swidth, 
int *sectorsize)
+static void blkid_get_topology(
+       const char *device,
+       int *sunit,
+       int *swidth,
+       int *sectorsize,
+       int force_overwrite)
 {
+
        blkid_topology tp;
        blkid_probe pr;
        unsigned long val;
@@ -409,6 +415,12 @@ static void blkid_get_topology(const char *device, int 
*sunit, int *swidth, int
                fprintf(stderr,
                        _("warning: device is not properly aligned %s\n"),
                        device);
+
+               if(!force_overwrite){
+                       fprintf(stderr, _("Use -f to force usage of a 
misaligned device\n"));
+                       exit(EXIT_FAILURE);
+               }
+       *sectorsize = BBSIZE;  /* Force a 512b sector size if the device is 
misaligned*/
        }
 
        blkid_free_probe(pr);
@@ -421,19 +433,19 @@ out_free_probe:
                device);
 }
 
-static void get_topology(libxfs_init_t *xi, struct fs_topology *ft)
+static void get_topology(libxfs_init_t *xi, struct fs_topology *ft, int 
force_overwrite)
 {
        if (!xi->disfile) {
                const char *dfile = xi->volname ? xi->volname : xi->dname;
 
                blkid_get_topology(dfile, &ft->dsunit, &ft->dswidth,
-                                  &ft->sectorsize);
+                                  &ft->sectorsize, force_overwrite);
        }
 
        if (xi->rtname && !xi->risfile) {
                int dummy;
 
-               blkid_get_topology(xi->rtname, &dummy, &ft->rtswidth, &dummy);
+               blkid_get_topology(xi->rtname, &dummy, &ft->rtswidth, &dummy, 
force_overwrite);
        }
 }
 #else /* ENABLE_BLKID */
@@ -460,7 +472,7 @@ check_overwrite(
        return 0;
 }
 
-static void get_topology(libxfs_init_t *xi, struct fs_topology *ft)
+static void get_topology(libxfs_init_t *xi, struct fs_topology *ft, int 
force_overwrite)
 {
        char *dfile = xi->volname ? xi->volname : xi->dname;
        int bsz = BBSIZE;
@@ -1625,7 +1637,7 @@ main(
        }
 
        memset(&ft, 0, sizeof(ft));
-       get_topology(&xi, &ft);
+       get_topology(&xi, &ft, force_overwrite);
 
        if (ft.sectoralign) {
                /*
-- 
1.7.6.4

<Prev in Thread] Current Thread [Next in Thread>