Re: [PATCH 4/4] xfs: fix the logspace waiting algorithm

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 4/4] xfs: fix the logspace waiting algorithm
From:	Ben Myers <bpm@xxxxxxx>
Date:	Wed, 30 Nov 2011 17:56:41 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20111128081925.981681380@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20111128081732.350228200@xxxxxxxxxxxxxxxxxxxxxx> <20111128081925.981681380@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

Christoph,

I feel that the ordering of the accesses to l_grant_head and the writeq
list may be important in the lockless path, and notice that they used to
be in opposite order.  It could use a comment explaining why (if) it is
ok.

-Ben

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/4] xfs fixes for Linux 3.2-rc3, Christoph Hellwig [PATCH 2/4] xfs: validate acl count, Christoph Hellwig [PATCH 1/4] xfs: fix attr2 vs large data fork assert, Christoph Hellwig Re: [PATCH 1/4] xfs: fix attr2 vs large data fork assert, Ben Myers Re: [PATCH 1/4] xfs: fix attr2 vs large data fork assert, Christoph Hellwig [PATCH 3/4] xfs: force buffer writeback before blocking on the ilock in inode reclaim, Christoph Hellwig [PATCH 4/4] xfs: fix the logspace waiting algorithm, Christoph Hellwig Re: [PATCH 4/4] xfs: fix the logspace waiting algorithm, Ben Myers <= Re: [PATCH 0/4] xfs fixes for Linux 3.2-rc3, Ben Myers Re: [PATCH 0/4] xfs fixes for Linux 3.2-rc3, Christoph Hellwig [PATCH 5/4] xfs: fix nfs export of 64-bit inodes numbers on 32-bit kernels, Christoph Hellwig

Previous by Date:	[PATCH 6/6] xfs: use doalloc flag in xfs_qm_dqattach_one(), Ben Myers
Previous by Thread:	[PATCH 4/4] xfs: fix the logspace waiting algorithm, Christoph Hellwig
Next by Thread:	Re: [PATCH 0/4] xfs fixes for Linux 3.2-rc3, Ben Myers
Indexes:	[Date] [Thread] [Top] [All Lists]