[Top] [All Lists]

[PATCH 1/6] xfs: don't serialise direct IO reads on page cache checks

To: greg@xxxxxxxxx, stable@xxxxxxxxxxxxxxx
Subject: [PATCH 1/6] xfs: don't serialise direct IO reads on page cache checks
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 30 Nov 2011 12:10:55 -0600
Cc: xfs@xxxxxxxxxxx, bpm@xxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>, Alex Elder <aelder@xxxxxxx>
In-reply-to: <1322676660-22945-1-git-send-email-bpm@xxxxxxx>
References: <20111128214018.GB1650@xxxxxxxxx> <1322676660-22945-1-git-send-email-bpm@xxxxxxx>
From: Dave Chinner <dchinner@xxxxxxxxxx>

commit 0c38a2512df272b14ef4238b476a2e4f70da1479 upstream.

There is no need to grab the i_mutex of the IO lock in exclusive
mode if we don't need to invalidate the page cache. Taking these
locks on every direct IO effective serialises them as taking the IO
lock in exclusive mode has to wait for all shared holders to drop
the lock. That only happens when IO is complete, so effective it
prevents dispatch of concurrent direct IO reads to the same inode.

Fix this by taking the IO lock shared to check the page cache state,
and only then drop it and take the IO lock exclusively if there is
work to be done. Hence for the normal direct IO case, no exclusive
locking will occur.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Tested-by: Joern Engel <joern@xxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
 fs/xfs/xfs_file.c |   17 ++++++++++++++---
 1 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 7f7b424..8fd4a07 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -317,7 +317,19 @@ xfs_file_aio_read(
        if (XFS_FORCED_SHUTDOWN(mp))
                return -EIO;
-       if (unlikely(ioflags & IO_ISDIRECT)) {
+       /*
+        * Locking is a bit tricky here. If we take an exclusive lock
+        * for direct IO, we effectively serialise all new concurrent
+        * read IO to this file and block it behind IO that is currently in
+        * progress because IO in progress holds the IO lock shared. We only
+        * need to hold the lock exclusive to blow away the page cache, so
+        * only take lock exclusively if the page cache needs invalidation.
+        * This allows the normal direct IO case of no page cache pages to
+        * proceeed concurrently without serialisation.
+        */
+       xfs_rw_ilock(ip, XFS_IOLOCK_SHARED);
+       if ((ioflags & IO_ISDIRECT) && inode->i_mapping->nrpages) {
+               xfs_rw_iunlock(ip, XFS_IOLOCK_SHARED);
                xfs_rw_ilock(ip, XFS_IOLOCK_EXCL);
                if (inode->i_mapping->nrpages) {
@@ -330,8 +342,7 @@ xfs_file_aio_read(
                xfs_rw_ilock_demote(ip, XFS_IOLOCK_EXCL);
-       } else
-               xfs_rw_ilock(ip, XFS_IOLOCK_SHARED);
+       }
        trace_xfs_file_read(ip, size, iocb->ki_pos, ioflags);

<Prev in Thread] Current Thread [Next in Thread>