xfs
[Top] [All Lists]

[PATCH 3/6] xfs: Return -EIO when xfs_vn_getattr() failed

To: greg@xxxxxxxxx, stable@xxxxxxxxxxxxxxx
Subject: [PATCH 3/6] xfs: Return -EIO when xfs_vn_getattr() failed
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 30 Nov 2011 12:10:57 -0600
Cc: xfs@xxxxxxxxxxx, bpm@xxxxxxx, Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>, Alex Elder <aelder@xxxxxxx>
In-reply-to: <1322676660-22945-1-git-send-email-bpm@xxxxxxx>
References: <20111128214018.GB1650@xxxxxxxxx> <1322676660-22945-1-git-send-email-bpm@xxxxxxx>
From: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>

commit ed32201e65e15f3e6955cb84cbb544b08f81e5a5 upstream.

An attribute of inode can be fetched via xfs_vn_getattr() in XFS.
Currently it returns EIO, not negative value, when it failed.  As a
result, the system call returns not negative value even though an
error occured. The stat(2), ls and mv commands cannot handle this
error and do not work correctly.

This patch fixes this bug, and returns -EIO, not EIO when an error
is detected in xfs_vn_getattr().

Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
---
 fs/xfs/xfs_iops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index 673704f..474920b 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -465,7 +465,7 @@ xfs_vn_getattr(
        trace_xfs_getattr(ip);
 
        if (XFS_FORCED_SHUTDOWN(mp))
-               return XFS_ERROR(EIO);
+               return -XFS_ERROR(EIO);
 
        stat->size = XFS_ISIZE(ip);
        stat->dev = inode->i_sb->s_dev;
-- 
1.7.8.rc0.46.g5ae0f

<Prev in Thread] Current Thread [Next in Thread>