xfs
[Top] [All Lists]

Re: [PATCH v2] xfs: Remove the entries from the queue while waking them

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH v2] xfs: Remove the entries from the queue while waking them up
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 29 Nov 2011 09:38:50 -0600
Cc: XFS Mailing List <xfs@xxxxxxxxxxx>
In-reply-to: <1321918880.7115.5.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1321918880.7115.5.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
Hey Chandra,

On Mon, Nov 21, 2011 at 05:41:20PM -0600, Chandra Seetharaman wrote:
> Changes from Verion 1:
> 
> - Added additional comments as per Dave's suggestion
> - Use next instead of tmp
> - change typedef xlog_ticket_t to struct xlog_ticket
> - Check t_queue before adding it to the list (the second time)
>   to accomodate system events (based on Christoph's comments)

FWIW, I reproduced a log hang yesterday in xfstest 273 while testing
this patch.  We'll have to see if Christoph's revision fares any better
today.

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>