| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: Sort recursive getfattr output in 062 |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 28 Nov 2011 06:03:02 -0500 |
| Cc: | Theodore Tso <tytso@xxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>, Yu Jian <yujian@xxxxxxxxxxxxx>, Andreas Dilger <adilger@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4ECD28D1.1080800@xxxxxxxxxx> |
| References: | <4EC10664.1080501@xxxxxxxxxxxx> <CAO47_-9nfO32nwOAQMVdqw6iWGWK+FWb+MD=WeOz_vr4YrrKmw@xxxxxxxxxxxxxx> <20111115142246.GA7516@xxxxxxxxx> <246EA1CC-3C33-4D41-80C0-2331C426EBB0@xxxxxxxxxxxxx> <4ECA4282.5020908@xxxxxxxxxxxxx> <401CC4FF-8955-4D5F-B620-5C39AF566123@xxxxxxx> <4ECB2ADE.3010007@xxxxxxxxxx> <4ECD28D1.1080800@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 23, 2011 at 11:09:37AM -0600, Eric Sandeen wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Test 062 was made "generic" a while back, but it fails on any filesystem > which returns getfattr -R results (aka readdir results) in something > other than inode-order. > > With a little awk-fu we can sort the records from getfattr -R so that > the output is the same for xfs as well as ext4, etc. > > Also filter out lost+found which extN creates at mkfs time, but > some other filesystems do not. Looks fine to me, except that I'd put the sorting helper into common.attr. Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: xfs: validate inode numbers in file handles correctly, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 0/6] XFS update for 3.1-stable, Greg KH |
| Previous by Thread: | [PATCH] xfstests: Sort recursive getfattr output in 062, Eric Sandeen |
| Next by Thread: | [PATCH] xfstests: mount other filesystems with selinux context as well, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |