xfs
[Top] [All Lists]

Re: [PATCH] libxfs: Get Physical Sector Size instead of Logical Sector s

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] libxfs: Get Physical Sector Size instead of Logical Sector size
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Thu, 24 Nov 2011 17:50:42 -0200
In-reply-to: <1322162451-17036-1-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1322162451-17036-1-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 24, 2011 at 05:20:51PM -0200, Carlos Maiolino wrote:
> xfsprogs (mainly mkfs) is using the logical sector size of a volume to 
> initialize
> the filesystem, which, even in devices using Advanced Format, it can get a 512
> bytes sector size if it is set as the logical sector size.
> This patch changes the ioctl to get the physical sector size, independent of 
> the
> logical size.
> 

Just as information, this patch proposal does not change the behaviour of mkfs 
in case the 
user is using libblkid, which in case, mkfs will take advantage of libblkid to 
retrieve disk
topology and information.
I'm not sure if libblkid is the best way to retrieve the device sector's size 
here, since 
this does not provide a way to retrive the physical sector size, only the 
logical size, but 
I can be very wrong.

-- 
--Carlos

<Prev in Thread] Current Thread [Next in Thread>