| To: | Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] 198, 240: check presence of aiodio_sparce2 |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 22 Nov 2011 20:33:16 +1100 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <4ECB3DCA.5000509@xxxxxxxxxxxxxx> |
| References: | <4ECB3DCA.5000509@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 22, 2011 at 03:14:34PM +0900, Hidetoshi Seto wrote: > Use same trick with: > commit 4e9072472fbc56b9d4c8ee8094cc62ce793df9b7 > Gracefully fail aio tests if they weren't built Good idea, but given this check is now repeated in multiple places, wrapping it in a "_require_aiodio" helper function is probably in order. It might also be useful to define AIODIO_SPARSE and AIODIO_SPARSE2 variables (similar to, say, XFS_IO_PROG) so that it doesn't have to be open coded in all the tests.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC][PATCH 0/8] xfstests: rework large filesystem testing, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] 198, 240: check presence of aiodio_sparce2, Hidetoshi Seto |
| Previous by Thread: | [PATCH] 198, 240: check presence of aiodio_sparce2, Hidetoshi Seto |
| Next by Thread: | Re: [PATCH] 198, 240: check presence of aiodio_sparce2, Hidetoshi Seto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |