xfs
[Top] [All Lists]

[PATCH 1/9] [PATCH 1/9] "xfs: fix error handling for synchronous writes"

To: stable@xxxxxxxxxxxxxxx
Subject: [PATCH 1/9] [PATCH 1/9] "xfs: fix error handling for synchronous writes"
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 19 Nov 2011 13:13:37 -0500
Cc: xfs@xxxxxxxxxxx, Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>, Alex Elder <aelder@xxxxxxx>
References: <20111119181336.964593075@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.48-1
xfs: fix for hang during synchronous buffer write error

If removed storage while synchronous buffer write underway,
"xfslogd" hangs.

Detailed log http://oss.sgi.com/archives/xfs/2011-07/msg00740.html

Related work bfc60177f8ab509bc225becbb58f7e53a0e33e81
"xfs: fix error handling for synchronous writes"

Given that xfs_bwrite actually does the shutdown already after
waiting for the b_iodone completion and given that we actually
found that calling xfs_force_shutdown from inside
xfs_buf_iodone_callbacks was a major contributor the problem
it better to drop this call.

Signed-off-by: Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
---
 fs/xfs/xfs_buf_item.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c
index a7342e8..7888a75 100644
--- a/fs/xfs/xfs_buf_item.c
+++ b/fs/xfs/xfs_buf_item.c
@@ -1023,7 +1023,6 @@ xfs_buf_iodone_callbacks(
        XFS_BUF_UNDELAYWRITE(bp);
 
        trace_xfs_buf_error_relse(bp, _RET_IP_);
-       xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR);
 
 do_callbacks:
        xfs_buf_do_callbacks(bp);
-- 
1.7.7


<Prev in Thread] Current Thread [Next in Thread>