xfs
[Top] [All Lists]

Re: [PATCH] change fallocate to xfs_io falloc

To: WuBo <wu.bo@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] change fallocate to xfs_io falloc
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 17 Nov 2011 14:50:33 -0600
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <4EC4989D.9080107@xxxxxxxxxxxxxx>
References: <4EB20505.7070005@xxxxxxxxxxxxxx> <4EC4989D.9080107@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
Hey Wu Bo,

On Thu, Nov 17, 2011 at 01:16:13PM +0800, WuBo wrote:
> Thanks to Ben for pointing it that the fallocate maybe uninstall 
> without checking it, and change fallocate to xfs_io as Christoph
> suggested.
> 
> Signed-off-by: Wu Bo <Wu.Bo@xxxxxxxxxxxxxx>

Nice!  It works great for me.  ;)

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Thanks,
        Ben

> ---
>  274 |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/274 b/274
> index b658004..bcf5a11 100755
> --- a/274
> +++ b/274
> @@ -46,6 +46,7 @@ _cleanup()
>  _supported_fs generic
>  _supported_os IRIX Linux
>  _require_scratch
> +_require_xfs_io_falloc
>  
>  echo "------------------------------"
>  echo "preallocation test"
> @@ -67,7 +68,7 @@ then
>       exit
>  fi
>  
> -fallocate -n -o 4K -l 1M test >/dev/null 2>&1
> +$XFS_IO_PROG -F -f -c 'falloc 4096 1m' test >/dev/null
>  if [ $? -ne 0 ]
>  then
>       echo "fallocate file err"
> -- 
> 1.7.3.1
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>