Re: [PATCH 4/5] xfs: log file size updates as part of unwritten extent conversion

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Nov 16, 2011 at 03:03:47PM -0600, Ben Myers wrote:
> > +           /*
> > +            * Log the updated inode size as we go.  We have to be careful
> > +            * to only log it up to the actual write offset if it is
> > +            * halfway into a block.
> > +            */
> > +           i_size = XFS_FSB_TO_B(mp, offset_fsb + count_fsb);
>                                                        ^^^^^^^^^
>                                                        imap.br_blockcount?

Indeed.

> Do you intend to log the new inode size based upon the entire request?

No.

> I discussed this a bit with Alex, and I think we agreed that it might be
> better to update the size based upon the length of the extent that was
> converted.

Yes, that was the intention, it just had a bug.