xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs: log file size updates as part of unwritten extent c

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 4/5] xfs: log file size updates as part of unwritten extent conversion
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 17 Nov 2011 02:48:26 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111116210347.GH29840@xxxxxxx>
References: <20111115201407.038216766@xxxxxxxxxxxxxxxxxxxxxx> <20111115201427.104680606@xxxxxxxxxxxxxxxxxxxxxx> <20111116210347.GH29840@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 16, 2011 at 03:03:47PM -0600, Ben Myers wrote:
> > +           /*
> > +            * Log the updated inode size as we go.  We have to be careful
> > +            * to only log it up to the actual write offset if it is
> > +            * halfway into a block.
> > +            */
> > +           i_size = XFS_FSB_TO_B(mp, offset_fsb + count_fsb);
>                                                        ^^^^^^^^^
>                                                        imap.br_blockcount?

Indeed.

> Do you intend to log the new inode size based upon the entire request?

No.

> I discussed this a bit with Alex, and I think we agreed that it might be
> better to update the size based upon the length of the extent that was
> converted.

Yes, that was the intention, it just had a bug.

<Prev in Thread] Current Thread [Next in Thread>