xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: use per-filesystem I/O completion workqueues

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: use per-filesystem I/O completion workqueues
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 17 Nov 2011 02:25:43 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111116232430.GB7046@dastard>
References: <20111115201407.038216766@xxxxxxxxxxxxxxxxxxxxxx> <20111115201426.686729205@xxxxxxxxxxxxxxxxxxxxxx> <20111116232430.GB7046@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 17, 2011 at 10:24:30AM +1100, Dave Chinner wrote:
> Don't need the undef here anymore as the #define is in the header
> file and not local to the function.

I'll fix it up.

> Can't say I'm a great fan of this - making the workqueue code use
> kstrdup() would be a much better better solution, IMO, just like was
> done a while for the SLAB cache names to solve exactly the same
> problem....

Tejun has a patch to make the name argument to alloc_workqueue both
dynamically allocated and varags format.  That'll fix it, but we can't
rely on it yet.  I will switch over to it later in the 3.3 cycle.

<Prev in Thread] Current Thread [Next in Thread>