xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfstests 265: add a prealloc and reserve test

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 2/3] xfstests 265: add a prealloc and reserve test
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 15 Nov 2011 14:08:21 -0500
Cc: WuBo <wu.bo@xxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Linux Btrfs <linux-btrfs@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111115182113.GD29840@xxxxxxx>
References: <4EB20505.7070005@xxxxxxxxxxxxxx> <4EB205CC.6010509@xxxxxxxxxxxxxx> <20111115182113.GD29840@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 15, 2011 at 12:21:13PM -0600, Ben Myers wrote:
> Hi Wu Bo,
> 
> On Thu, Nov 03, 2011 at 11:09:00AM +0800, WuBo wrote:
> > This test is for preallocation test. If the disk is full, just with a 
> > prealloc
> > file has some free space that prealloc early. We need to check whether the 
> > write
> > to the free space is success or not.
> > 
> > Signed-off-by: Wu Bo <Wu.Bo@xxxxxxxxxxxxxx>
> 
> This test is failing for me because I don't have fallocate installed.  I
> suggest the test could to be changed to check for binaries it uses,
> possibly the version of those binaries, and then not run unless the
> right ones are installed.  But the best I can do right now is make a
> note of it.

It might be even better to just use the xfs_io falloc command as we
generally expect an uptodate xfs_io for use with xfstests.

<Prev in Thread] Current Thread [Next in Thread>