xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfsprogs: xfs_db: unmount fs before exiting

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 6/8] xfsprogs: xfs_db: unmount fs before exiting
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 13 Nov 2011 07:09:18 -0500
Cc: xfs@xxxxxxxxxxx, Kevan Rehm <kfr@xxxxxxx>
In-reply-to: <f91d3489cdc9ad68b6dac8224cf761fb2c51ad1e.1320955676.git.aelder@xxxxxxx>
References: <3ed89446f6dc1231ec1de712f242522052952b7e.1320955675.git.aelder@xxxxxxx> <f91d3489cdc9ad68b6dac8224cf761fb2c51ad1e.1320955676.git.aelder@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 10, 2011 at 02:35:16PM -0600, Alex Elder wrote:
> From: Kevan Rehm <kfr@xxxxxxx>
> 
> The main routine calls libxfs_mount() via init(), but never calls
> libxfs_umount() at the end of the program so there could be
> filesystem changes queued which never get flushed to disk.  This
> adds the missing libxfs_umount() call.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>