xfs
[Top] [All Lists]

Re: [PATCH] [BUGFIX] xfs: use doalloc flag in xfs_qm_dqattach_one()

To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Subject: Re: [PATCH] [BUGFIX] xfs: use doalloc flag in xfs_qm_dqattach_one()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 10 Nov 2011 02:37:07 -0500
Cc: Alex Elder <aelder@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, yrl.pp-manager.tt@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx
In-reply-to: <20111110013310.3408.41745.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20111110013310.3408.41745.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 10, 2011 at 10:33:10AM +0900, Mitsuo Hayasaka wrote:
> The doalloc arg in xfs_qm_dqattach_one() is a flag that indicates
> whether a new area to handle quota information will be allocated
> if needed. Originally, it was passed to xfs_qm_dqget(), but has
> been removed by the following commit (probably by mistake):
> 
>       commit 8e9b6e7fa4544ea8a0e030c8987b918509c8ff47
>       Author: Christoph Hellwig <hch@xxxxxx>
>       Date:   Sun Feb 8 21:51:42 2009 +0100
> 
>       xfs: remove the unused XFS_QMOPT_DQLOCK flag
> 
> As the result, xfs_qm_dqget() called from xfs_qm_dqattach_one()
> never allocates the new area even if it is needed.
> 
> This patch gives the doalloc arg to xfs_qm_dqget() in
> xfs_qm_dqattach_one() to fix this problem.

Thanks a lot, this is a good fix.  Do you have a good testcase
showing the effect?

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>