Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node

To:	Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject:	Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 8 Nov 2011 14:07:22 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1320777990-6556-2-git-send-email-cmaiolino@xxxxxxxxxx>
References:	<1320777990-6556-1-git-send-email-cmaiolino@xxxxxxxxxx> <1320777990-6556-2-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Nov 08, 2011 at 04:46:29PM -0200, Carlos Maiolino wrote:
> dd get_inode_offset() inline function, which will return the offset
> of a specific node in the AVL tree avoiding the need to calculate the
> the offset each time it needs to be used.

Looks good.  We should also use it a bit more, but I can take care of
that.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2] Set lost+found inode as used after its allocation, Carlos Maiolino [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Carlos Maiolino Re: [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Eric Sandeen Re: [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Christoph Hellwig [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Carlos Maiolino Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Eric Sandeen Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Carlos Maiolino Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Christoph Hellwig <= [PATCH 0/2] Set lost+found inode as used after its allocation, Carlos Maiolino [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Carlos Maiolino Re: [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Ben Myers [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Carlos Maiolino Re: [PATCH 0/2] Set lost+found inode as used after its allocation, Christoph Hellwig Re: [PATCH 0/2] Set lost+found inode as used after its allocation, Carlos Maiolino

Previous by Date:	Re: [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Christoph Hellwig
Next by Date:	Re: quota mismatch for NFS mount of XFS filesystem, Dave Chinner
Previous by Thread:	Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Carlos Maiolino
Next by Thread:	[PATCH 0/2] Set lost+found inode as used after its allocation, Carlos Maiolino
Indexes:	[Date] [Thread] [Top] [All Lists]