xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 8 Nov 2011 14:07:22 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1320777990-6556-2-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1320777990-6556-1-git-send-email-cmaiolino@xxxxxxxxxx> <1320777990-6556-2-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 08, 2011 at 04:46:29PM -0200, Carlos Maiolino wrote:
> dd get_inode_offset() inline function, which will return the offset
> of a specific node in the AVL tree avoiding the need to calculate the
> the offset each time it needs to be used.

Looks good.  We should also use it a bit more, but I can take care of
that.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>