Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node
From:	Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date:	Tue, 8 Nov 2011 17:02:12 -0200
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<4EB97B53.7080600@xxxxxxxxxxx>
References:	<1320777990-6556-1-git-send-email-cmaiolino@xxxxxxxxxx> <1320777990-6556-2-git-send-email-cmaiolino@xxxxxxxxxx> <4EB97B53.7080600@xxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-12-10)

On Tue, Nov 08, 2011 at 12:56:19PM -0600, Eric Sandeen wrote:
> On 11/8/11 12:46 PM, Carlos Maiolino wrote:
> > dd get_inode_offset() inline function, which will return the offset
> > of a specific node in the AVL tree avoiding the need to calculate the
> > the offset each time it needs to be used.
> 
> might be good to find the open-coded instances of this, and
> make them use the helper too.
> 
> -Eric
> 
Yep, I can trck down these instances and replace by this function later
with no problem

-- 
--Carlos

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2] Set lost+found inode as used after its allocation, Carlos Maiolino [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Carlos Maiolino Re: [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Eric Sandeen Re: [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Christoph Hellwig [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Carlos Maiolino Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Eric Sandeen Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Carlos Maiolino <= Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Christoph Hellwig [PATCH 0/2] Set lost+found inode as used after its allocation, Carlos Maiolino [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Carlos Maiolino Re: [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Ben Myers [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Carlos Maiolino Re: [PATCH 0/2] Set lost+found inode as used after its allocation, Christoph Hellwig Re: [PATCH 0/2] Set lost+found inode as used after its allocation, Carlos Maiolino

Previous by Date:	Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Eric Sandeen
Next by Date:	Re: [PATCH 2/2] xfs_repair: Properly set lost+found inode as used, Christoph Hellwig
Previous by Thread:	Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Eric Sandeen
Next by Thread:	Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]