[Top] [All Lists]

Re: [PATCH v2 8/8] xfsdump: enable multiple streams

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH v2 8/8] xfsdump: enable multiple streams
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 7 Nov 2011 20:03:34 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1320699511-12281-9-git-send-email-wkendall@xxxxxxx>
References: <1320699511-12281-1-git-send-email-wkendall@xxxxxxx> <1320699511-12281-9-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-11-07 at 14:58 -0600, Bill Kendall wrote:
> IRIX contained an environment referred to as "miniroot" where
> sproc threads were either not available, or at least not used
> in xfsdump. Throughout xfsdump there's a "miniroot" variable
> which indicates whether or not thread support is enabled. On
> Linux this variable has always been false in order to disable
> support for multiple streams.
> Now that the threading infracstructure has been converted over
> to pthreads, this patch removes the "miniroot" variable and
> enables the option of using multiple streams.
> Note that another feature in xfsdump, using a ring buffer for
> I/O to tapes, also depends on thread support. I'm leaving that
> disabled for now until more testing has been done.
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Really, really nice work Bill.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>