xfs
[Top] [All Lists]

Re: [PATCH v2 7/8] xfsdump: path lookup cache must be thread specific

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH v2 7/8] xfsdump: path lookup cache must be thread specific
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 7 Nov 2011 20:03:27 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1320699511-12281-8-git-send-email-wkendall@xxxxxxx>
References: <1320699511-12281-1-git-send-email-wkendall@xxxxxxx> <1320699511-12281-8-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-11-07 at 14:58 -0600, Bill Kendall wrote:
> The xfsrestore path lookup routine (maps an ino + generation number to a
> pathname) contains a cache for fast lookups of consecutive files in the
> same parent directory. This cache either needs to be protected by a lock
> or a cache is needed per thread. I took the latter approach since it
> doesn't add lock contention and it increases the cache hit rate (it's
> relatively unlikely that each stream is processing files in the same
> directory).
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

So you're fixing a bug, and making it work
better at the same time, by simply adding one
keyword.

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>