xfs
[Top] [All Lists]

Re: [PATCH v2 5/8] xfsdump: convert IRIX sproc threads to pthreads

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH v2 5/8] xfsdump: convert IRIX sproc threads to pthreads
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 7 Nov 2011 20:02:20 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1320699511-12281-6-git-send-email-wkendall@xxxxxxx>
References: <1320699511-12281-1-git-send-email-wkendall@xxxxxxx> <1320699511-12281-6-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-11-07 at 14:58 -0600, Bill Kendall wrote:
> The existing (disabled) threading code in xfsdump is based on IRIX
> sprocs. This patch converts the code to use pthreads. The threading code
> remains disabled at this point.
> 
> Changes:
>    - pid_t to pthread_t
>    - getpid() to pthread_self()
>    - "pid1 == pid2" to pthread_equal(tid1, tid2)
>    - sigprocmask() to pthread_sigmask()
>    - sproc() to pthread_create()
> 
> Also the following are not referenced and have been removed:
>    - cldmgr_pid2streamix()
>    - PROCMAX
>    - r_slavepid
>    - sproc.c and sproc.h
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>