xfs
[Top] [All Lists]

Re: [PATCH v2 3/8] xfsdump: implement lock abstraction with pthreads

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH v2 3/8] xfsdump: implement lock abstraction with pthreads
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 7 Nov 2011 20:02:11 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1320699511-12281-4-git-send-email-wkendall@xxxxxxx>
References: <1320699511-12281-1-git-send-email-wkendall@xxxxxxx> <1320699511-12281-4-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-11-07 at 14:58 -0600, Bill Kendall wrote:
> This patch implements xfsdump's locking abstraction using pthread
> locking primitives. The obsolete IRIX locking code has been removed.
> 
> The POSIX semaphore implementation on Linux does not provide a count
> of threads waiting to decrement the semaphore, so qsemPblocked()
> has been removed. It was called from a few asserts, but the current
> count of the semaphore was also checked in adjacent asserts, so
> it was deemed acceptable to remove the qsemPblocked() asserts.
> 
> A few debug-level log calls had to be changed to use the "no lock"
> flag to prevent locks from being acquired out of order. This is
> used in various debug messages throughout xfsdump.
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

I have not done a very thorough review, but this
looks OK to me.

                                        -Alex


<Prev in Thread] Current Thread [Next in Thread>