xfs
[Top] [All Lists]

Re: [PATCH v2 2/8] xfsdump: remove multi-stream synchronous dir dump

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH v2 2/8] xfsdump: remove multi-stream synchronous dir dump
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 7 Nov 2011 20:02:06 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1320699511-12281-3-git-send-email-wkendall@xxxxxxx>
References: <1320699511-12281-1-git-send-email-wkendall@xxxxxxx> <1320699511-12281-3-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-11-07 at 14:58 -0600, Bill Kendall wrote:
> When doing multi-stream dumps, the directories are dumped by each
> stream in lock-step fashion. A stream backs up a given directory,
> then waits for all others to finish that directory, then they all
> move on to the next one. During restore a single stream is chosen to
> apply the directory dump.
> 
> This patch changes xfsdump so that only one stream dumps the
> directories. The other streams begin dumping files immediately.
> This results in a faster backup, which is presumably why multiple
> streams are being used in the first place.
> 
> It also removes the barrier routines in qlock.c as they were only
> used by the "SYNCDIR" code.
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Nice change.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>