xfs
[Top] [All Lists]

[PATCH v2 7/8] xfsdump: path lookup cache must be thread specific

To: xfs@xxxxxxxxxxx
Subject: [PATCH v2 7/8] xfsdump: path lookup cache must be thread specific
From: Bill Kendall <wkendall@xxxxxxx>
Date: Mon, 7 Nov 2011 14:58:30 -0600
Cc: Bill Kendall <wkendall@xxxxxxx>
In-reply-to: <1320699511-12281-1-git-send-email-wkendall@xxxxxxx>
References: <1320699511-12281-1-git-send-email-wkendall@xxxxxxx>
The xfsrestore path lookup routine (maps an ino + generation number to a
pathname) contains a cache for fast lookups of consecutive files in the
same parent directory. This cache either needs to be protected by a lock
or a cache is needed per thread. I took the latter approach since it
doesn't add lock contention and it increases the cache hit rate (it's
relatively unlikely that each stream is processing files in the same
directory).

Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
---
 restore/tree.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/restore/tree.c b/restore/tree.c
index 7bddddf..9e4e83c 100644
--- a/restore/tree.c
+++ b/restore/tree.c
@@ -3441,7 +3441,7 @@ Node2path( nh_t nh, char *path, char *errmsg )
 static intgen_t
 Node2path_recurse( nh_t nh, char *buf, intgen_t bufsz, intgen_t level )
 {
-       static path_cache_t cache = { NH_NULL, 0, "" };
+       static __thread path_cache_t cache = { NH_NULL, 0, "" };
        node_t *np;
        nh_t parh;
        xfs_ino_t ino;
-- 
1.7.0.4

<Prev in Thread] Current Thread [Next in Thread>