xfs
[Top] [All Lists]

Re: [PATCH] path: fix 1 byte overflow with empty lists

To: Mike Frysinger <vapier@xxxxxxxxxx>
Subject: Re: [PATCH] path: fix 1 byte overflow with empty lists
From: Bill Kendall <wkendall@xxxxxxx>
Date: Mon, 07 Nov 2011 09:14:34 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1320554817-2594-1-git-send-email-vapier@xxxxxxxxxx>
References: <1320554817-2594-1-git-send-email-vapier@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110921 Thunderbird/3.1.15
On 11/05/2011 11:46 PM, Mike Frysinger wrote:
If pap->pa_cnt is 0, then the local buffer is allocated as 1 byte,
but the code then writes two bytes to it '/' and '\0'.

Signed-off-by: Mike Frysinger<vapier@xxxxxxxxxx>

Looks good,

Reviewed-by: Bill Kendall <wkendall@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>